Page MenuHomeSoftware Heritage
Differential D2181

Rename 'cursor' to 'scroll_token'.
ClosedPublic
Actions

Authored by vlorentz on Oct 28 2019, 1:53 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSEAe7668999bcfa: Rename 'cursor' to 'scroll_token'.
Summary

'cursor' has a different meaning in our components using postgresql;
this renaming will avoid confusion when adding token-based pagination
to these components.

Diff Detail

Repository
rDSEA Archive search
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 28 2019, 1:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 28 2019, 1:53 PM
swh-public-ci added a comment.Oct 28 2019, 1:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/1/ for more details.

Harbormaster completed remote builds in B8643: Diff 7438.Oct 28 2019, 1:55 PM
vlorentz updated this revision to Diff 7439.Oct 28 2019, 1:56 PM

remove TODO

swh-public-ci added a comment.Oct 28 2019, 1:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/2/ for more details.

Harbormaster completed remote builds in B8644: Diff 7439.Oct 28 2019, 1:58 PM
olasd accepted this revision.Oct 29 2019, 1:35 PM
olasd added a subscriber: olasd.
olasd added inline comments.
swh/search/elasticsearch.py
116–117

This sentence is missing word.

This revision is now accepted and ready to land.Oct 29 2019, 1:35 PM
vlorentz updated this revision to Diff 7460.Oct 29 2019, 1:41 PM

fix typo

This revision was landed with ongoing or failed builds.Oct 29 2019, 1:41 PM
Closed by commit rDSEAe7668999bcfa: Rename 'cursor' to 'scroll_token'. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSEAe7668999bcfa: Rename 'cursor' to 'scroll_token'..
Harbormaster failed remote builds in B8665: Diff 7460!Oct 29 2019, 1:41 PM
swh-public-ci added a comment.Oct 29 2019, 1:41 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tox/3/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tox/3/console

Revision Contents
Changeset List

PathSize
swh/
search/
23 lines
17 lines
tests/
2 lines
24 lines
12 lines

Diff 7461

View Options

swh/search/elasticsearch.py

Loading...
View Options

swh/search/in_memory.py

Loading...
View Options

swh/search/tests/test_cli.py

Loading...
View Options

swh/search/tests/test_search.py

Loading...
View Options

swh/search/utils.py

Loading...
About · Developer information · Legal