Differential D2179

test_write_replay: Handle all possible hypothesis inputs
ClosedPublic
Actions

Authored by anlambert on Oct 25 2019, 5:15 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDJNL4ee80e37c881: test_write_replay: Handle all possible hypothesis inputs

Summary

Two reasons this test could fail based on input generated by hypothesis:

HashCollision when adding a content to the first storage as hypotesis can generate duplicated content examples
failed assertion when hypothesis generate a content example with a status different from visible

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 25 2019, 5:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 25 2019, 5:15 PM

anlambert added a child revision: D2180: Remove references to origin type and update tests.Oct 25 2019, 5:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/278/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/278/console

Harbormaster failed remote builds in B8639: Diff 7434!Oct 25 2019, 5:19 PM

olasd accepted this revision.Oct 26 2019, 3:59 PM

This revision is now accepted and ready to land.Oct 26 2019, 3:59 PM

This revision was landed with ongoing or failed builds.Oct 26 2019, 4:13 PM

Closed by commit rDJNL4ee80e37c881: test_write_replay: Handle all possible hypothesis inputs (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDJNL4ee80e37c881: test_write_replay: Handle all possible hypothesis inputs.

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

test_write_replay.py

14 lines

Diff 7436

View Options

swh/journal/tests/test_write_replay.py

test_write_replay: Handle all possible hypothesis inputsClosedPublicActions