Differential D2174

model: make to_dict() properly recursive
ClosedPublic
Actions

Authored by olasd on Oct 23 2019, 1:56 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDMOD4b79a2b0b7ca: model: make to_dict() properly recursive

Summary

Instead of relying on attr.asdict recursion, we do recursion ourselves. This
simplifies a lot of the inherited to_dict() methods.

Test Plan

tox output is unchanged

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 23 2019, 1:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 23 2019, 1:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/140/ for more details.

Harbormaster completed remote builds in B8617: Diff 7414.Oct 23 2019, 1:57 PM

Cleaner recursion

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/141/ for more details.

Harbormaster completed remote builds in B8619: Diff 7416.Oct 23 2019, 2:12 PM

olasd mentioned this in D2157: Stop supporting origin ids in API (except in origin_get_range)..Oct 23 2019, 2:19 PM

Looks good !

This revision is now accepted and ready to land.Oct 23 2019, 2:21 PM

Rebase

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/142/ for more details.

Harbormaster completed remote builds in B8627: Diff 7422.Oct 23 2019, 2:24 PM

Closed by commit rDMOD4b79a2b0b7ca: model: make to_dict() properly recursive (authored by olasd). · Explain WhyOct 23 2019, 2:27 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDMOD4b79a2b0b7ca: model: make to_dict() properly recursive.

Revision Contents
Changeset List

Path

Size

swh/

model/

model.py

49 lines

Diff 7423

View Options

model: make to_dict() properly recursiveClosedPublicActions