Differential D2173

Remove origin['type']
ClosedPublic
Actions

Authored by olasd on Oct 23 2019, 1:12 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSTOC28818ab7f97a: Remove origin['type']
rDSTO28818ab7f97a: Remove origin['type']

Summary

This is now superseded by origin_visit['type']

Depends on D2170

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 23 2019, 1:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 23 2019, 1:12 PM

Looks good, bye bye origin type !

This revision is now accepted and ready to land.Oct 23 2019, 1:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/758/ for more details.

Harbormaster completed remote builds in B8613: Diff 7411.Oct 23 2019, 1:30 PM

olasd added a child revision: D2157: Stop supporting origin ids in API (except in origin_get_range)..Oct 23 2019, 2:06 PM

Closed by commit rDSTO28818ab7f97a: Remove origin['type'] (authored by olasd). · Explain WhyOct 23 2019, 2:20 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO28818ab7f97a: Remove origin['type'].

olasd added a commit: rDSTOC28818ab7f97a: Remove origin['type'].Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

Path

Size

sql/

upgrades/

142.sql

10 lines

swh/

storage/

db.py

8 lines

in_memory.py

14 lines

sql/

30-swh-schema.sql

4 lines

storage.py

10 lines

tests/

algos/

test_origin.py

6 lines

storage_data.py

2 lines

test_storage.py

7 lines

Diff 7421

View Options

sql/upgrades/142.sql

View Options

swh/storage/db.py

View Options

swh/storage/in_memory.py

View Options

swh/storage/sql/30-swh-schema.sql

View Options

swh/storage/storage.py

View Options

swh/storage/tests/algos/test_origin.py

View Options

swh/storage/tests/storage_data.py

View Options

swh/storage/tests/test_storage.py

Remove origin['type']ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7421

sql/upgrades/142.sql

swh/storage/db.py

swh/storage/in_memory.py

swh/storage/sql/30-swh-schema.sql

swh/storage/storage.py

swh/storage/tests/algos/test_origin.py

swh/storage/tests/storage_data.py

swh/storage/tests/test_storage.py

Remove origin['type']
ClosedPublic
Actions

Revision Contents
Changeset List