Page MenuHomeSoftware Heritage

Better handle aliases in snapshot content

Authored by anlambert on Oct 22 2019, 3:47 PM.



Fix some issues related to aliases in snapshot content spotted after D2078 landing.

Basically, some redirections were missing as such cases were not yet encountered.

Depends on D2167

Diff Detail

rDWAPPS Web applications
No Linters Available
No Unit Test Coverage
Build Status
Buildable 8602
Build 12501: Cypress tests for swh-web diffsJenkins
Build 12500: tox-on-jenkinsJenkins
Build 12499: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 22 2019, 3:47 PM
olasd accepted this revision.Oct 23 2019, 12:09 PM
olasd added a subscriber: olasd.

There's nothing in the spec that would prevent having to follow a chain of aliases, but I guess a single step resolution is good enough for now.

I suggest that at some point the "branch alias resolution" moves to the module as a generic tool: I think it would make sense to have a "get the target directory for this branch on this snapshot" function, which would return the list of objects traversed up to the directory: branch aliases, releases, revisions.

This will also prepare us for the resolution of T1258.

This revision is now accepted and ready to land.Oct 23 2019, 12:09 PM
This revision was automatically updated to reflect the committed changes.