Page MenuHomeSoftware Heritage
Differential D2166

deposit: Migrate last tests to pytest
ClosedPublic
Actions

Authored by ardumont on Oct 21 2019, 3:16 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Commits
rDDEP9b65a13d8f6a: swh.deposit.tests: Drop dead code
rDDEP7f3c655952fa: tests.loader: Migrate to pytest
rDDEPd5a394a4e0b7: tests.checker: Migrate to pytest
rDDEP89a466ee72d7: tests.loader: Migrate test_client to pytest
rDDEP44f590684736: tox.ini: Update tox.ini requirements
Summary

Ensure ci is green

Related T1579

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8593
Build 12484: tox-on-jenkinsJenkins
Build 12483: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 21 2019, 3:16 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 21 2019, 3:16 PM
ardumont retitled this revision from tests: Migrate last tests to pytest to deposit: Migrate last tests to pytest.Oct 21 2019, 3:17 PM
swh-public-ci added a comment.Oct 21 2019, 3:18 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/189/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/189/console

Harbormaster failed remote builds in B8591: Diff 7390!Oct 21 2019, 3:18 PM
ardumont updated this revision to Diff 7391.Oct 21 2019, 3:20 PM

annoyingly, local tox and ci tox are not the same...

Adding back what i think is missing

swh-public-ci added a comment.Oct 21 2019, 3:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/190/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/190/console

Harbormaster failed remote builds in B8592: Diff 7391!Oct 21 2019, 3:22 PM
ardumont updated this revision to Diff 7392.Oct 21 2019, 3:25 PM

Apparently pifpaf is still needed...

ardumont edited the summary of this revision. (Show Details)Oct 21 2019, 3:25 PM
swh-public-ci added a comment.Oct 21 2019, 3:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/191/ for more details.

Harbormaster completed remote builds in B8593: Diff 7392.Oct 21 2019, 3:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2019, 3:47 PM
Closed by commit rDDEP44f590684736: tox.ini: Update tox.ini requirements (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEP44f590684736: tox.ini: Update tox.ini requirements.
ardumont added a commit: rDDEP89a466ee72d7: tests.loader: Migrate test_client to pytest.
ardumont added a commit: rDDEPd5a394a4e0b7: tests.checker: Migrate to pytest.
ardumont added a commit: rDDEP7f3c655952fa: tests.loader: Migrate to pytest.
ardumont added a commit: rDDEP9b65a13d8f6a: swh.deposit.tests: Drop dead code.

Revision Contents
Changeset List

PathSize
2 lines
2 lines
swh/
deposit/
loader/
22 lines
8 lines
tests/
api/
3 lines
448 lines
16 lines
loader/
72 lines
53 lines
data/
http_example.org/
3 lines
1 line
https_deposit.softwareheritage.org/
1 line
3 lines
69 lines
1 line
https_nowhere.org/
1 line
3 lines
3 lines
81 lines
300 lines
254 lines
18 lines
11 lines

Diff 7392

View Options

requirements-swh.txt

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/deposit/loader/checker.py

Loading...
View Options

swh/deposit/loader/tasks.py

Loading...
View Options

swh/deposit/tests/api/test_common.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_list.py

Loading...
View Options

swh/deposit/tests/common.py

Loading...
View Options

swh/deposit/tests/conftest.py

Loading...
View Options

swh/deposit/tests/loader/common.py

Loading...
View Options

swh/deposit/tests/loader/conftest.py

Loading...
View Options

swh/deposit/tests/loader/data/http_example.org/hello.json

Loading...
View Options

swh/deposit/tests/loader/data/http_example.org/hello_you

Loading...
View Options

swh/deposit/tests/loader/data/https_deposit.softwareheritage.org/1_private_test_1_check

Loading...
View Options

swh/deposit/tests/loader/data/https_deposit.softwareheritage.org/1_private_test_2_check

Loading...
View Options

swh/deposit/tests/loader/data/https_deposit.softwareheritage.org/1_private_test_999_meta

Loading...
View Options

swh/deposit/tests/loader/data/https_deposit.softwareheritage.org/1_private_test_999_raw

Loading...
View Options

swh/deposit/tests/loader/data/https_deposit.softwareheritage.org/1_private_test_999_update

Loading...
View Options

swh/deposit/tests/loader/data/https_nowhere.org/1_private_test_1_check

Loading...
View Options

swh/deposit/tests/loader/data/https_nowhere.org/1_private_test_1_metadata

Loading...
View Options

swh/deposit/tests/loader/data/https_nowhere.org/1_private_test_1_raw

Loading...
View Options

swh/deposit/tests/loader/test_checker.py

Loading...
View Options

swh/deposit/tests/loader/test_client.py

Loading...
View Options

swh/deposit/tests/loader/test_loader.py

Loading...
View Options

swh/deposit/tests/loader/test_tasks.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal