Page MenuHomeSoftware Heritage
Differential D2155

lister-debian: Install debian model within the lister repository
ClosedPublic
Actions

Authored by ardumont on Oct 17 2019, 6:05 PM.

Details

Reviewers
vlorentz
douardda
Group Reviewers
Reviewers
Commits
rDLS7c247c8a4a28: debian/lister: Use url parameter name instead of origin
rDLS56d7cff6e122: debian/model: Install lister model within the lister repository
Summary

As this is no longer shared between the new debian loader and the lister.

This is just a move from swh.storage.schemata.distribution to swh.lister.debian.models towards sandboxing the model where it's needed.

Also, it aligns the scheduled task parameter from origin to url as other package loaders expects.

Related D2135

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Branch
debian-update
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8526
Build 12385: tox-on-jenkinsJenkins
Build 12384: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 17 2019, 6:05 PM
ardumont retitled this revision from debian/model: Install lister model within the lister repository to lister-debian: Install debian model within the lister repository.Oct 17 2019, 6:06 PM
swh-public-ci added a comment.Oct 17 2019, 6:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/447/ for more details.

Harbormaster completed remote builds in B8526: Diff 7327.Oct 17 2019, 6:09 PM
ardumont edited the summary of this revision. (Show Details)Oct 17 2019, 6:09 PM
douardda added a comment.Oct 18 2019, 4:50 PM

LGTM (with a ci msg stating why it's still in storage for now)

douardda accepted this revision.Oct 18 2019, 4:50 PM
This revision is now accepted and ready to land.Oct 18 2019, 4:50 PM
ardumont updated this revision to Diff 7356.Oct 18 2019, 7:00 PM

Amend commit message as required.

swh-public-ci added a comment.Oct 18 2019, 7:41 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/456/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/456/console

Harbormaster failed remote builds in B8555: Diff 7356!Oct 18 2019, 7:41 PM
ardumont updated this revision to Diff 7405.EditedOct 23 2019, 1:01 PM

Rebase to latest master

(which should fix the ci)

swh-public-ci added a comment.Oct 23 2019, 1:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/460/ for more details.

Harbormaster completed remote builds in B8607: Diff 7405.Oct 23 2019, 1:04 PM
ardumont updated this revision to Diff 7602.Nov 4 2019, 10:01 AM

Rebase on latest master

swh-public-ci added a comment.Nov 4 2019, 10:04 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/464/ for more details.

Harbormaster completed remote builds in B8764: Diff 7602.Nov 4 2019, 10:04 AM
ardumont updated this revision to Diff 7604.Nov 4 2019, 10:06 AM

Plug to branch master

swh-public-ci added a comment.Nov 4 2019, 10:11 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/466/ for more details.

Harbormaster completed remote builds in B8766: Diff 7604.Nov 4 2019, 10:11 AM
Closed by commit rDLS56d7cff6e122: debian/model: Install lister model within the lister repository (authored by ardumont). · Explain WhyNov 4 2019, 10:13 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLS56d7cff6e122: debian/model: Install lister model within the lister repository.
ardumont added a commit: rDLS7c247c8a4a28: debian/lister: Use url parameter name instead of origin.

Revision Contents
Changeset List

PathSize
1 line
swh/
lister/
debian/
2 lines
251 lines
tests/
2 lines

Diff 7327

View Options

requirements-swh.txt

Loading...
View Options

swh/lister/debian/lister.py

Loading...
View Options

swh/lister/debian/models.py

Loading...
View Options

swh/lister/debian/tests/test_lister.py

Loading...
About · Developer information · Legal