Differential D2081

swh identify -t snapshot: add support for symbolic refs
ClosedPublic
Actions

Authored by zack on Oct 8 2019, 9:53 AM.

Details

Reviewers

Commits

rDMOD2e4558c0d2d5: test_cli.py: fill in valid snapshot ID
rDMOD8e3ee395d3c7: test_cli.py: drop unused NoQA marker
rDMOD4a742055c299: swh identify -t snapshot: add support for symbolic refs

Diff Detail

Repository

rDMOD Data model

Branch

feature/identify-symref

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8564
Build 12450: tox-on-jenkins	Jenkins
Build 12449: arc lint + arc unit

Event Timeline

zack created this revision.Oct 8 2019, 9:53 AM

zack added a parent revision: D2078: Add support for symbolic references.Oct 8 2019, 9:53 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/133/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/133/console

Harbormaster failed remote builds in B8159: Diff 6990!Oct 8 2019, 9:54 AM

This change looks apporpriate. Of course, you'll need to update the expected snapshot hash for the tests to pass.

zack mentioned this in D2078: Add support for symbolic references.Oct 20 2019, 9:34 AM

test_cli.py: drop unused NoQA marker
test_cli.py: fill in valid snapshot ID

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/138/ for more details.

Harbormaster completed remote builds in B8561: Diff 7362.Oct 20 2019, 9:40 AM

swh identify -t snapshot: add support for symbolic refs
test_cli.py: drop unused NoQA marker
test_cli.py: fill in valid snapshot ID

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/139/ for more details.

Harbormaster completed remote builds in B8564: Diff 7363.Oct 20 2019, 9:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 20 2019, 9:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rDMOD4a742055c299: swh identify -t snapshot: add support for symbolic refs (authored by zack). · Explain Why

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDMOD4a742055c299: swh identify -t snapshot: add support for symbolic refs.

zack added a commit: rDMOD8e3ee395d3c7: test_cli.py: drop unused NoQA marker.

zack added a commit: rDMOD2e4558c0d2d5: test_cli.py: fill in valid snapshot ID.

Revision Contents
Changeset List

Path

Size

swh/

model/

cli.py

7 lines

tests/

test_cli.py

7 lines

Diff 7363

View Options

swh/model/cli.py