Note that this requires mypy to be installed in the "swh-tox" docker image, but
I didn't know how to make sure that's the case. Tips welcome.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rCJSWH6e46253416fd: add optional mypy invocation to the CI pipeline (swh-pipeline)
I haven't tested it, because I don't know how to. Tips welcome.
Diff Detail
Diff Detail
- Repository
- rCJSWH Jenkins jobs
- Branch
- feature/mypy
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8095 Build 11671: arc lint + arc unit
Event Timeline
Comment Actions
Looks good to me.
In order to test the generated XML files for Jenkins are valid, you can run tox at the top level directory of that repository.
To install mypy in the docker image used to run the tests, you have to modify that Dockerfile.
You will have to land the dockerfile change prior to that diff of course.
Comment Actions
Thanks for the tip.
Although in the end this is actually not needed, as mypy is declared as a dependency in the mypy environments, so tox will take care of installing it as needed. No need to change the docker image. (My bad.)