Differential D2064

test_storage: Close all pool connections on teardown
ClosedPublic
Actions

Authored by olasd on Oct 2 2019, 5:23 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC24ea71f77213: test_storage: Close all pool connections on teardown
rDSTO24ea71f77213: test_storage: Close all pool connections on teardown

Summary

This avoids having a race condition between the tear down and the database
removal, when using more than one connection in the pool.

Test Plan

tox runs without failing

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 2 2019, 5:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 2 2019, 5:23 PM

olasd added a child revision: D2065: Replace all 'inmemory' journal writers with 'memory'.Oct 2 2019, 5:24 PM

olasd added a child revision: D2066: Postgres storage: introduce a db() context manager.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/660/ for more details.

Harbormaster completed remote builds in B8083: Diff 6940.Oct 2 2019, 5:28 PM

anlambert accepted this revision.Oct 2 2019, 5:51 PM

This revision is now accepted and ready to land.Oct 2 2019, 5:51 PM

Closed by commit rDSTO24ea71f77213: test_storage: Close all pool connections on teardown (authored by olasd). · Explain WhyOct 2 2019, 5:57 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO24ea71f77213: test_storage: Close all pool connections on teardown.

olasd added a commit: rDSTOC24ea71f77213: test_storage: Close all pool connections on teardown.Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_storage.py

2 lines

Diff 6946

View Options

swh/storage/tests/test_storage.py

test_storage: Close all pool connections on teardownClosedPublicActions