Page MenuHomeSoftware Heritage
Differential D2051

Make the null compression use the "none" identifier instead of None
ClosedPublic
Actions

Authored by olasd on Sep 30 2019, 10:37 PM.

Details

Reviewers
douardda
Commits
rDOBJS5a37cbc9f4c2: Make the null compression use the "none" identifier instead of None
Summary

This is friendlier to configuration files

Depends on D2049
Depends on D2050

Test Plan

tox

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Sep 30 2019, 10:37 PM
swh-public-ci added a comment.Sep 30 2019, 10:53 PM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/89/ for more details.

Harbormaster completed remote builds in B8015: Diff 6873.Sep 30 2019, 10:53 PM
douardda accepted this revision.Oct 1 2019, 9:44 AM

See my comment, just in case.

swh/objstorage/tests/test_objstorage_azure.py
112

I tend to prefer the if a == b when both the if and else blocks are there.

This revision is now accepted and ready to land.Oct 1 2019, 9:44 AM
olasd updated this revision to Diff 6901.Oct 1 2019, 11:40 AM

Switch conditions to get a ==

olasd marked an inline comment as done.Oct 1 2019, 11:40 AM
swh-public-ci added a comment.Oct 1 2019, 11:43 AM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/90/ for more details.

Harbormaster completed remote builds in B8045: Diff 6901.Oct 1 2019, 11:43 AM
Closed by commit rDOBJS5a37cbc9f4c2: Make the null compression use the "none" identifier instead of None (authored by olasd). · Explain WhyOct 1 2019, 11:53 AM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDOBJS5a37cbc9f4c2: Make the null compression use the "none" identifier instead of None.

Revision Contents
Changeset List

Diff 6902

View Options

swh/objstorage/objstorage.py

Loading...
View Options

swh/objstorage/tests/test_objstorage_azure.py

Loading...
View Options

swh/objstorage/tests/test_objstorage_cloud.py

Loading...
View Options

swh/objstorage/tests/test_objstorage_pathslicing.py

Loading...
View Options

swh/objstorage/tests/test_objstorage_seaweedfs.py

Loading...
About · Developer information · Legal