Differential D2022

typing: minimal changes to make a no-op mypy run pass
ClosedPublic
Actions

Authored by zack on Sep 21 2019, 8:43 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDOBJS400fd28b0e5c: MockBlockBlobService: make data a protected _data attribute
rDOBJS953ca42788d3: typing: convert a swh.objstorage variable annotation to comment style
rDOBJSfbd022a2a8e5: typing: minimal changes to make a no-op mypy run pass

Test Plan

tox -e mypy

Diff Detail

Repository

rDOBJS Object storage

Branch

feature/typing

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7924
Build 11411: tox-on-jenkins	Jenkins
Build 11410: arc lint + arc unit

Event Timeline

zack created this revision.Sep 21 2019, 8:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 21 2019, 8:43 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/77/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/77/console

Harbormaster failed remote builds in B7905: Diff 6794!Sep 21 2019, 8:43 PM

typing: convert a swh.objstorage variable annotation to comment style

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/78/ for more details.

Harbormaster completed remote builds in B7906: Diff 6795.Sep 21 2019, 8:48 PM

vlorentz requested changes to this revision.Sep 21 2019, 9:25 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/objstorage/api/server.py
8	why?
swh/objstorage/tests/test_objstorage_azure.py
30	It should be a protected attribute

This revision now requires changes to proceed.Sep 21 2019, 9:25 PM

zack marked an inline comment as done.Sep 22 2019, 4:02 PM

zack added inline comments.

swh/objstorage/api/server.py
8	The json module is used down in that file, line 129, but the missing import is not flagged by flake8 because the same line, for different reasons (an assigned lambda), has a NoQA marker. The missing import is caught by mypy though, hence I've added the import.
swh/objstorage/tests/test_objstorage_azure.py
30	I'm not sure what you mean here. You want a heading "_" added, a getter, or what?

zack added a child revision: D2023: typing: minimal changes to make a no-op mypy run pass.Sep 22 2019, 4:08 PM

MockBlockBlobService: make data a protected _data attribute

diff updated, addressing comments

vlorentz accepted this revision.Sep 24 2019, 10:50 AM

This revision is now accepted and ready to land.Sep 24 2019, 10:50 AM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/79/ for more details.

Harbormaster completed remote builds in B7924: Diff 6810.Sep 24 2019, 10:52 AM

Closed by commit rDOBJSfbd022a2a8e5: typing: minimal changes to make a no-op mypy run pass (authored by zack). · Explain WhySep 24 2019, 10:52 AM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDOBJSfbd022a2a8e5: typing: minimal changes to make a no-op mypy run pass.

zack added a commit: rDOBJS953ca42788d3: typing: convert a swh.objstorage variable annotation to comment style.

zack added a commit: rDOBJS400fd28b0e5c: MockBlockBlobService: make data a protected _data attribute.

Revision Contents
Changeset List

Path

Size

1 line

1 line

21 lines

swh/

5 lines

objstorage/

3 lines

api/

1 line

1 line

tests/

test_objstorage_azure.py

22 lines

10 lines

Diff 6810

.gitignore

Loading...

MANIFEST.in

Loading...

mypy.ini

Loading...

swh/init.py

Loading...

swh/objstorage/init.py

Loading...

swh/objstorage/api/server.py

Loading...

swh/objstorage/py.typed

Loading...

swh/objstorage/tests/test_objstorage_azure.py

Loading...

tox.ini

Loading...