Page MenuHomeSoftware Heritage
Differential D1978

Implement timeouts for cloning repositories
ClosedPublic
Actions

Authored by olasd on Sep 10 2019, 5:34 PM.

Details

Reviewers
anlambert
Commits
rDLDHG04fda5962f5e: Implement timeouts for cloning repositories
Summary

This is a workaround for T1962.

Test Plan

tox unittests the timeout behavior

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Sep 10 2019, 5:34 PM
anlambert requested changes to this revision.Sep 10 2019, 5:51 PM

CI builds are currently failing due to the use of Process.kill method (not available in Python 3.5)

swh/loader/mercurial/loader.py
166

Process.kill has been introduced in Python 3.7

207–212

Just a nitpick, you could add the timeout unity in the debug message.

This revision now requires changes to proceed.Sep 10 2019, 5:51 PM
swh-public-ci added a comment.Sep 10 2019, 6:05 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tox/33/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tox/33/console

Harbormaster failed remote builds in B7753: Diff 6667!Sep 10 2019, 6:05 PM
olasd updated this revision to Diff 6668.Sep 10 2019, 6:06 PM

Use process.terminate instead of process.kill (3.5-compatible)

swh/loader/mercurial/loader.py
166

*barf*

olasd updated this revision to Diff 6669.Sep 10 2019, 6:07 PM

Show timeout unit in log message

olasd marked 2 inline comments as done.Sep 10 2019, 6:07 PM
swh-public-ci added a comment.Sep 10 2019, 6:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDHG/job/tox/34/ for more details.

Harbormaster completed remote builds in B7754: Diff 6668.Sep 10 2019, 6:07 PM
anlambert accepted this revision.Sep 10 2019, 6:08 PM

Looks good to me

This revision is now accepted and ready to land.Sep 10 2019, 6:08 PM
swh-public-ci added a comment.Sep 10 2019, 6:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDHG/job/tox/35/ for more details.

Harbormaster completed remote builds in B7755: Diff 6669.Sep 10 2019, 6:08 PM
Closed by commit rDLDHG04fda5962f5e: Implement timeouts for cloning repositories (authored by olasd). · Explain WhySep 10 2019, 6:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
loader/
mercurial/
55 lines
tests/
1 line
55 lines

Diff 6670

View Options

swh/loader/mercurial/loader.py

Loading...
View Options

swh/loader/mercurial/tests/common.py

Loading...
View Options

swh/loader/mercurial/tests/test_loader.py

Loading...
About · Developer information · Legal