Page MenuHomeSoftware Heritage

Convert 'transplant_source' extra header to bytehex
ClosedPublic

Authored by vlorentz on Tue, Sep 10, 4:24 PM.

Details

Summary

extra header values should always be bytes, and make swh-storage
crash if they are not.

Bug introduced in D1507.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, Sep 10, 4:24 PM
vlorentz planned changes to this revision.Tue, Sep 10, 4:58 PM

Looks like we're heading to bytehex digests instead of bytes digests

vlorentz updated this revision to Diff 6674.Wed, Sep 11, 11:32 AM

use bytehex instead of bytes

vlorentz retitled this revision from Convert 'transplant_source' extra header to bytes. to Convert 'transplant_source' extra header to bytehex.Wed, Sep 11, 11:32 AM
ardumont accepted this revision.Wed, Sep 11, 11:45 AM
This revision is now accepted and ready to land.Wed, Sep 11, 11:45 AM
vlorentz updated this revision to Diff 6675.Wed, Sep 11, 11:45 AM

no more need for raw string

This revision was landed with ongoing or failed builds.Wed, Sep 11, 11:45 AM
This revision was automatically updated to reflect the committed changes.