Page MenuHomeSoftware Heritage
Differential D1949

models: use the same declarative base class for all models
ClosedPublic
Actions

Authored by douardda on Sep 4 2019, 11:53 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLS631b8e7668a5: models: use the same declarative base class for all models
Summary

This is needed to fix the db-init implementation so the debian loader (which
does use the SQLBase from swh.storage) have its models declared in the
MetaData used by the initialize() function.

Depends on D1947

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 4 2019, 11:53 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 4 2019, 11:53 AM
douardda added a child revision: D1950: tasks: normalize the url argument name of most lister.Sep 4 2019, 11:53 AM
Harbormaster failed remote builds in B7637: Diff 6562!Sep 4 2019, 11:54 AM
swh-public-ci added a comment.Sep 4 2019, 11:55 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/343/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/343/console

ardumont accepted this revision.Sep 4 2019, 2:58 PM
This revision is now accepted and ready to land.Sep 4 2019, 2:58 PM
douardda updated this revision to Diff 6585.Sep 4 2019, 3:44 PM

rebase

Harbormaster failed remote builds in B7660: Diff 6585!Sep 4 2019, 3:44 PM
swh-public-ci added a comment.Sep 4 2019, 3:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/350/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/350/console

swh-public-ci added a comment.Sep 4 2019, 4:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/354/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/354/console

swh-public-ci added a comment.Sep 4 2019, 4:43 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/357/ for more details.

Harbormaster completed remote builds in B7660: Diff 6585.Sep 4 2019, 4:43 PM
Closed by commit rDLS631b8e7668a5: models: use the same declarative base class for all models (authored by douardda). · Explain WhySep 4 2019, 4:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
lister/
core/
7 lines

Diff 6595

View Options

swh/lister/core/models.py

Loading...
About · Developer information · Legal