Differential D1925

phabricator: kill PhabricatorLister's api_token argument
ClosedPublic
Actions

Authored by douardda on Aug 30 2019, 6:01 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLS83d138759ce8: phabricator: kill PhabricatorLister's api_token argument

Summary

stick to the existing credentials mechanism provided by ListerHttpTransport.

Depends on D1924

Diff Detail

Repository

rDLS Listers

Branch

plugins

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 7537
Build 10776: tox-on-jenkins	Jenkins
Build 10775: arc lint + arc unit

Event Timeline

douardda created this revision.Aug 30 2019, 6:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2019, 6:01 PM

douardda added a child revision: D1926: phabricator: small refactoring/simplification of the request_params method.Aug 30 2019, 6:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/310/ for more details.

Harbormaster completed remote builds in B7537: Diff 6481.Aug 30 2019, 6:05 PM

ardumont accepted this revision.Aug 31 2019, 7:54 AM

This revision is now accepted and ready to land.Aug 31 2019, 7:54 AM

Closed by commit rDLS83d138759ce8: phabricator: kill PhabricatorLister's api_token argument (authored by douardda). · Explain WhySep 2 2019, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

phabricator/

lister.py

6 lines

tests/

test_lister.py

11 lines

Diff 6481

View Options

swh/lister/phabricator/lister.py