Differential D1924

core: move credentials' docstring from request_params to request_instance_credentials
ClosedPublic
Actions

Authored by douardda on Aug 30 2019, 6:01 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLS6f56d2c8d72d: core: move credentials' docstring from request_params to…

Summary

and fix empty values returned by this later (empty list instead of ampty dict).

Diff Detail

Repository

rDLS Listers

Branch

plugins

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 7536
Build 10774: tox-on-jenkins	Jenkins
Build 10773: arc lint + arc unit

Event Timeline

douardda created this revision.Aug 30 2019, 6:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2019, 6:01 PM

douardda added a child revision: D1925: phabricator: kill PhabricatorLister's api_token argument.Aug 30 2019, 6:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/309/ for more details.

Harbormaster completed remote builds in B7536: Diff 6480.Aug 30 2019, 6:03 PM

ardumont accepted this revision.Aug 31 2019, 7:53 AM

This revision is now accepted and ready to land.Aug 31 2019, 7:53 AM

Closed by commit rDLS6f56d2c8d72d: core: move credentials' docstring from request_params to… (authored by douardda). · Explain WhySep 2 2019, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

core/

lister_transports.py

57 lines

Diff 6480

View Options

swh/lister/core/lister_transports.py

core: move credentials' docstring from request_params to request_instance_credentialsClosedPublicActions