Page MenuHomeSoftware Heritage
Differential D1911

identifiers.py: add constants for 'swh:1' and sanitize namespace
ClosedPublic
Actions

Authored by zack on Aug 23 2019, 6:35 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDMOD880aff9d2d73: identifiers.py: add constants for 'swh:1' and sanitize namespace
Test Plan

pytest

Diff Detail

Repository
rDMOD Data model
Branch
feature/pid-consts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7441
Build 10605: tox-on-jenkinsJenkins
Build 10604: arc lint + arc unit

Event Timeline

zack created this revision.Aug 23 2019, 6:35 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 23 2019, 6:35 PM
swh-public-ci added a comment.Aug 23 2019, 6:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/119/ for more details.

Harbormaster completed remote builds in B7441: Diff 6403.Aug 23 2019, 6:36 PM
vlorentz added a subscriber: vlorentz.Aug 23 2019, 6:48 PM

What is this for?

zack added a child revision: D1912: swh identify: add support for origin PIDs.Aug 23 2019, 7:02 PM
zack added a comment.Aug 23 2019, 7:12 PM
In D1911#44122, @vlorentz wrote:

What is this for?

refactoring, removing hard-coded constants here and there, and sanitize a namespace that could (even though it isn't yet, expect for tests) used from the outside

zack removed a child revision: D1912: swh identify: add support for origin PIDs.Aug 23 2019, 7:12 PM
vlorentz added a comment.Aug 23 2019, 7:13 PM

I don't really see what was wrong with hardcoding :, but * shrug *

vlorentz accepted this revision.Aug 23 2019, 7:13 PM
This revision is now accepted and ready to land.Aug 23 2019, 7:13 PM
Closed by commit rDMOD880aff9d2d73: identifiers.py: add constants for 'swh:1' and sanitize namespace (authored by zack). · Explain WhyAug 23 2019, 7:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
model/
39 lines
tests/
8 lines

Diff 6403

View Options

swh/model/identifiers.py

Loading...
View Options

swh/model/tests/test_identifiers.py

Loading...
About · Developer information · Legal