Page MenuHomeSoftware Heritage
Differential D1891

Provide visit type when calling origin_visit_add.
ClosedPublic
Actions

Authored by vlorentz on Aug 22 2019, 4:17 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDLDBASEcc3c233266ae: Provide visit type when calling origin_visit_add.
Summary

Instead of origin_visit_add falling back to the origin's type.

This will require diffs in other loaders, to set the visit_type
attribute.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 22 2019, 4:17 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 22 2019, 4:17 PM
Harbormaster completed remote builds in B7390: Diff 6353.Aug 22 2019, 4:19 PM
swh-public-ci added a comment.Aug 22 2019, 4:19 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/152/ for more details.

vlorentz mentioned this in D1892: Add attribute visit_type to debian loader.Aug 22 2019, 4:21 PM
vlorentz mentioned this in D1893: Add attribute visit_type to git loader.
vlorentz mentioned this in D1894: Add attribute visit_type to mercurial loader..
vlorentz mentioned this in D1895: Add attribute visit_type to npm loader..
vlorentz mentioned this in D1896: Add attribute visit_type to pypi loader..
vlorentz mentioned this in D1899: Add attribute visit_type to tar loader.Aug 22 2019, 4:25 PM
vlorentz mentioned this in D1898: Add attribute visit_type to svn loader..Aug 22 2019, 4:25 PM
vlorentz updated this revision to Diff 6363.Aug 22 2019, 4:45 PM

rename type_ to visit_type.

swh-public-ci added a comment.Aug 22 2019, 4:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/154/ for more details.

Harbormaster completed remote builds in B7400: Diff 6363.Aug 22 2019, 4:46 PM
olasd accepted this revision.Aug 22 2019, 4:47 PM
This revision is now accepted and ready to land.Aug 22 2019, 4:47 PM
vlorentz updated this revision to Diff 6373.Aug 22 2019, 4:51 PM

rebase

This revision was landed with ongoing or failed builds.Aug 22 2019, 4:51 PM
Closed by commit rDLDBASEcc3c233266ae: Provide visit type when calling origin_visit_add. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B7410: Diff 6373!Aug 22 2019, 4:52 PM
swh-public-ci added a comment.Aug 22 2019, 4:52 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/155/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/155/console

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
11 lines
tests/
3 lines
package/
4 lines

Diff 6374

View Options

swh/loader/core/loader.py

Loading...
View Options

swh/loader/core/tests/test_loader.py

Loading...
View Options

swh/loader/package/loader.py

Loading...
About · Developer information · Legal