Differential D1888

Remove references to person['id'].
ClosedPublic
Actions

Authored by vlorentz on Aug 22 2019, 11:56 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDWAPPS1ff55896a46e: Remove references to person['id'].

Summary

Person ids will be removed in swh-storage v0.0.148.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7368
Build 10481: Cypress tests for swh-web diffs	Jenkins
Build 10480: tox-on-jenkins	Jenkins
Build 10479: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 22 2019, 11:56 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 22 2019, 11:56 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/687/ for more details.

Also remove unknown_person().

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/287/ for more details.

Harbormaster completed remote builds in B7368: Diff 6331.Aug 22 2019, 12:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/688/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/288/ for more details.

Harbormaster completed remote builds in B7369: Diff 6332.Aug 22 2019, 12:23 PM

I wonder why these strategies were never used... Anyway, thanks!

This revision is now accepted and ready to land.Aug 22 2019, 1:49 PM

Because of D1869.

Closed by commit rDWAPPS1ff55896a46e: Remove references to person['id']. (authored by vlorentz). · Explain WhyAug 22 2019, 1:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

tests/

data.py

5 lines

strategies.py

8 lines

Diff 6331

View Options

swh/web/tests/data.py