Make origin_add/origin_visit_update validate their input.
ClosedPublic
Actions

Authored by vlorentz on Aug 21 2019, 5:32 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOCbc3240da6668: Make origin_add/origin_visit_update validate their input.
rDSTObc3240da6668: Make origin_add/origin_visit_update validate their input.

Summary

Depends on D1878, D1884, and D1885.

Diff Detail

Repository

rDSTO Storage manager

Branch

origin-origin_visit-validation

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7357
Build 10457: tox-on-jenkins	Jenkins
Build 10456: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 21 2019, 5:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 21 2019, 5:32 PM

Harbormaster failed remote builds in B7357: Diff 6320!Aug 21 2019, 5:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/595/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/595/console

vlorentz edited the summary of this revision. (Show Details)Aug 21 2019, 5:46 PM

vlorentz added parent revisions: D1885: Add missing fields status/type/snapshot/metadata to OriginVisit., D1884: Make OriginVisit use datetime for its date..

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/597/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/597/console

Looks good, need to check the build failure though.

It's just because Arcanist is bad at applying patches. (If diff A depends on B and B depends on C and D, "arc patch A" will try to apply patches C and D even if they are on different repos or are closed)

ok then ;)

This revision is now accepted and ready to land.Aug 29 2019, 12:23 PM

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/626/ for more details.

Harbormaster completed remote builds in B7514: Diff 6464.Aug 29 2019, 1:54 PM

Closed by commit rDSTObc3240da6668: Make origin_add/origin_visit_update validate their input. (authored by vlorentz). · Explain WhyAug 30 2019, 11:06 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOCbc3240da6668: Make origin_add/origin_visit_update validate their input..Oct 30 2019, 5:21 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

in_memory.py

153 lines

tests/

test_storage.py

28 lines

Diff 6320

View Options

swh/storage/in_memory.py