Page MenuHomeSoftware Heritage
Differential D1873

Make directory_add validate its input.
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2019, 5:20 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC6946edbba4ce: Make directory_add validate its input.
rDSTO6946edbba4ce: Make directory_add validate its input.
Summary

Depends on D1865.

Diff Detail

Repository
rDSTO Storage manager
Branch
directory_add-validation
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7343
Build 10429: tox-on-jenkinsJenkins
Build 10428: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 20 2019, 5:20 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2019, 5:20 PM
Harbormaster failed remote builds in B7343: Diff 6306!Aug 20 2019, 5:21 PM
swh-public-ci added a comment.Aug 20 2019, 5:21 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/589/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/589/console

vlorentz updated this revision to Diff 6307.Aug 20 2019, 5:23 PM

fix typo

Harbormaster failed remote builds in B7344: Diff 6307!Aug 20 2019, 5:23 PM
swh-public-ci added a comment.Aug 20 2019, 5:23 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/590/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/590/console

vlorentz added a child revision: D1874: Make revision_add and release_add validate their input..Aug 20 2019, 5:25 PM
vlorentz updated this revision to Diff 6345.Aug 22 2019, 3:35 PM

rebase

Harbormaster failed remote builds in B7382: Diff 6345!Aug 22 2019, 3:36 PM
swh-public-ci added a comment.Aug 22 2019, 3:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/602/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/602/console

swh-public-ci added a comment.Aug 22 2019, 3:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/604/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/604/console

swh-public-ci added a comment.Aug 22 2019, 3:47 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/609/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/609/console

swh-public-ci added a comment.Aug 22 2019, 3:51 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/610/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/610/console

swh-public-ci added a comment.Aug 22 2019, 3:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/611/ for more details.

Harbormaster completed remote builds in B7382: Diff 6345.Aug 22 2019, 3:57 PM
ardumont accepted this revision.Aug 27 2019, 10:12 AM
ardumont added a subscriber: ardumont.

sounds good

This revision is now accepted and ready to land.Aug 27 2019, 10:12 AM
ardumont added inline comments.Aug 27 2019, 10:13 AM
swh/storage/sql/30-swh-schema.sql
176

You need to bump the version 139 in this file as well.

vlorentz updated this revision to Diff 6457.Aug 29 2019, 11:33 AM

rebase + update schema version

This revision was landed with ongoing or failed builds.Aug 29 2019, 11:33 AM
Closed by commit rDSTO6946edbba4ce: Make directory_add validate its input. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B7507: Diff 6457!Aug 29 2019, 11:33 AM
swh-public-ci added a comment.Aug 29 2019, 11:33 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/623/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/623/console

vlorentz added a commit: rDSTOC6946edbba4ce: Make directory_add validate its input..Oct 30 2019, 5:21 PM

Revision Contents
Changeset List

PathSize
sql/
upgrades/
19 lines
swh/
storage/
16 lines
sql/
18 lines
4 lines
tests/
14 lines

Diff 6306

View Options

sql/upgrades/139.sql

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/sql/30-swh-schema.sql

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal