Page MenuHomeSoftware Heritage
Differential D1869

Drop the "person_get" API + browse endpoints.
ClosedPublic
Actions

Authored by vlorentz on Aug 19 2019, 4:08 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDWAPPSa7ad7484659e: Drop the "person_get" API + browse endpoints.
Summary

They take a person id as argument, which is pretty much useless,
as the only way to get a person id is through "release_get" and
"revision_get" API/browse endpoints, which also give the full information.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 19 2019, 4:08 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 19 2019, 4:08 PM
vlorentz updated this revision to Diff 6270.Aug 19 2019, 4:09 PM

rename commit

vlorentz retitled this revision from Drop the "person_get" API + UI endpoints. to Drop the "person_get" API + browse endpoints..Aug 19 2019, 4:09 PM
vlorentz edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Aug 19 2019, 4:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/674/ for more details.

swh-public-ci added a comment.Aug 19 2019, 4:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/675/ for more details.

swh-public-ci added a comment.Aug 19 2019, 4:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/273/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/273/console

Harbormaster failed remote builds in B7305: Diff 6269!Aug 19 2019, 4:30 PM
swh-public-ci added a comment.Aug 19 2019, 4:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/274/ for more details.

Harbormaster completed remote builds in B7306: Diff 6270.Aug 19 2019, 4:42 PM
vlorentz mentioned this in D1870: Remove person_get endpoint..Aug 19 2019, 4:48 PM
olasd accepted this revision.Aug 19 2019, 5:10 PM
This revision is now accepted and ready to land.Aug 19 2019, 5:10 PM
swh-public-ci added a comment.Aug 19 2019, 5:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/276/ for more details.

vlorentz updated this revision to Diff 6285.Aug 20 2019, 10:19 AM

rebase

This revision was landed with ongoing or failed builds.Aug 20 2019, 10:19 AM
Closed by commit rDWAPPSa7ad7484659e: Drop the "person_get" API + browse endpoints. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B7321: Diff 6285!Aug 20 2019, 10:20 AM
swh-public-ci added a comment.Aug 20 2019, 10:20 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/278/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/278/console

swh-public-ci added a comment.Aug 20 2019, 10:20 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/678/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/678/console

vlorentz mentioned this in D1888: Remove references to person['id']..Aug 22 2019, 1:51 PM

Revision Contents
Changeset List

PathSize
swh/
web/
api/
1 line
15 lines
views/
3 lines
6 lines
browse/
1 line
22 lines
views/
6 lines
12 lines
common/
5 lines
19 lines
tests/
api/
14 lines
11 lines
views/
9 lines
10 lines
browse/
10 lines
views/
7 lines
13 lines
common/
9 lines
4 lines

Diff 6286

View Options

swh/web/api/urls.py

Loading...
View Options

swh/web/api/utils.py

Loading...
View Options

swh/web/api/views/person.py

Loading...
View Options

swh/web/api/views/release.py

Loading...
View Options

swh/web/api/views/revision.py

Loading...
View Options

swh/web/browse/urls.py

Loading...
View Options

swh/web/browse/utils.py

Loading...
View Options

swh/web/browse/views/person.py

Loading...
View Options

swh/web/browse/views/release.py

Loading...
View Options

swh/web/browse/views/revision.py

Loading...
View Options

swh/web/common/converters.py

Loading...
View Options

swh/web/common/service.py

Loading...
View Options

swh/web/tests/api/test_apidoc.py

Loading...
View Options

swh/web/tests/api/test_utils.py

Loading...
View Options

swh/web/tests/api/views/test_person.py

Loading...
View Options

swh/web/tests/api/views/test_release.py

Loading...
View Options

swh/web/tests/api/views/test_revision.py

Loading...
View Options

swh/web/tests/browse/test_utils.py

Loading...
View Options

swh/web/tests/browse/views/test_person.py

Loading...
View Options

swh/web/tests/browse/views/test_release.py

Loading...
View Options

swh/web/tests/browse/views/test_revision.py

Loading...
View Options

swh/web/tests/common/test_service.py

Loading...
View Options

swh/web/tests/testcase.py

Loading...
About · Developer information · Legal