Differential D1750

Send smaller batches to revision_get
ClosedPublic
Actions

Authored by vlorentz on Jul 18 2019, 4:55 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDCIDX44234a2a8752: Send smaller batches to revision_get

Summary

to avoid getting a timeout.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 18 2019, 4:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/577/ for more details.

Harbormaster completed remote builds in B6929: Diff 5894.Jul 18 2019, 4:57 PM

ardumont accepted this revision.Jul 18 2019, 5:53 PM

ardumont added inline comments.

swh/indexer/metadata.py
286	i'm wondering whether that should be storage side or not ;) (what i suggested earlier was possibly to do that storage side) Well, we'll see what this does.

This revision is now accepted and ready to land.Jul 18 2019, 5:53 PM

vlorentz added inline comments.Jul 19 2019, 11:15 AM

swh/indexer/metadata.py
286	Doing it on the storage side is exactly the same as increasing the timeout.

Closed by commit rDCIDX44234a2a8752: Send smaller batches to revision_get (authored by vlorentz). · Explain WhyJul 19 2019, 11:15 AM

This revision was automatically updated to reflect the committed changes.

ardumont mentioned this in T1788: indexer-license: Investigate timeouts.Sep 24 2019, 4:25 PM

Revision Contents
Changeset List

Path

Size

swh/

indexer/

10 lines

Diff 5899

swh/indexer/metadata.py

Loading...