Differential D1706

tarball: extract safemembers() from within _uncompress_tar()
ClosedPublic
Actions

Authored by douardda on Jul 10 2019, 10:22 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE9e29cfaec429: tarball: extract safemembers() from within _uncompress_tar()

Summary

No need for it being a dynamically defined function, plus it makes pydocstyle
very unhappy (probably a bug in pydoctyle 4.0.0 but...).

Also rename it as _safemembers() for consistency sake.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

safemembers

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 6743
Build 9422: tox-on-jenkins	Jenkins
Build 9421: arc lint + arc unit

Event Timeline

douardda created this revision.Jul 10 2019, 10:22 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2019, 10:22 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/248/ for more details.

Harbormaster completed remote builds in B6743: Diff 5721.Jul 10 2019, 10:24 AM

ardumont accepted this revision.Jul 10 2019, 10:25 AM

This revision is now accepted and ready to land.Jul 10 2019, 10:25 AM

Closed by commit rDCORE9e29cfaec429: tarball: extract safemembers() from within _uncompress_tar() (authored by douardda). · Explain WhyJul 10 2019, 10:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

core/

tarball.py

69 lines

Diff 5721

View Options

tarball: extract safemembers() from within _uncompress_tar()ClosedPublicActions