Differential D1681

settings/production: remove hard written allowed hosts
ClosedPublic
Actions

Authored by douardda on Jul 3 2019, 12:10 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPSd8323f147bc0: settings/production: remove hard written allowed hosts

Summary

these constants should be set in the SWH_CONFIG_FILENAME at deployment,
they have no reason to live in the code.

Warning: this probably imply updating the puppet deployment stuff.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6652
Build 9293: tox-on-jenkins	Jenkins
Build 9292: arc lint + arc unit

Event Timeline

douardda created this revision.Jul 3 2019, 12:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2019, 12:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/577/ for more details.

Harbormaster completed remote builds in B6652: Diff 5642.Jul 3 2019, 12:23 PM

anlambert added a child revision: D1682: Move webapp allowed hosts from code to configuration.Jul 3 2019, 1:32 PM

D1682 created to update configuration through puppet.

This revision is now accepted and ready to land.Jul 3 2019, 1:33 PM

Closed by commit rDWAPPSd8323f147bc0: settings/production: remove hard written allowed hosts (authored by douardda). · Explain WhyJul 3 2019, 1:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

settings/

production.py

10 lines

Diff 5642

View Options

swh/web/settings/production.py

settings/production: remove hard written allowed hostsClosedPublicActions