Paths

Table of Contentst

Differential D1676

Make the in-memory storage use URLs instead of ids as its 'primary key' internally.
ClosedPublic
Actions

Authored by vlorentz on Jul 2 2019, 4:54 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOCaf2d253a4790: Make the in-memory storage use URLs instead of ids as its 'primary key'…
rDSTOaf2d253a4790: Make the in-memory storage use URLs instead of ids as its 'primary key'…

Summary

This is a first step toward disabling origin-ids entirely.

Depends on D1675

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 2 2019, 4:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 2 2019, 4:54 PM

Harbormaster failed remote builds in B6630: Diff 5621!Jul 2 2019, 5:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/534/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/534/console

douardda added a subscriber: douardda.Jul 3 2019, 10:00 AM

douardda added inline comments.

swh/storage/in_memory.py
1021	dumb question but aren't `self._origins` and `self._origins_by_id` supposed to be the same length?

vlorentz added inline comments.Jul 3 2019, 10:12 AM

swh/storage/in_memory.py
1021	Yes, they are. It's just that `origin_from` is used as an index in `self._origins_by_id` so it makes more sense this way, but both are equivalent.

vlorentz added a parent revision: D1675: Make origin_visit_upsert take an origin dict instead of int..Jul 3 2019, 10:13 AM

vlorentz edited the summary of this revision. (Show Details)

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/537/ for more details.

Harbormaster completed remote builds in B6639: Diff 5631.Jul 3 2019, 10:40 AM

change base commit

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/538/ for more details.

Harbormaster completed remote builds in B6648: Diff 5638.Jul 3 2019, 12:10 PM

douardda accepted this revision.Jul 3 2019, 3:57 PM

This revision is now accepted and ready to land.Jul 3 2019, 3:57 PM

Closed by commit rDSTOaf2d253a4790: Make the in-memory storage use URLs instead of ids as its 'primary key'… (authored by vlorentz). · Explain WhyJul 3 2019, 3:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

210 lines

tests/

test_storage.py

19 lines

Diff 5650

swh/storage/in_memory.py

Loading...

swh/storage/tests/test_storage.py

Loading...