Page MenuHomeSoftware Heritage
Differential D1607

Remove argument origin_id from call to Loader.send_origin_metadata.
ClosedPublic
Actions

Authored by vlorentz on Jun 18 2019, 5:15 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEPe03e819599ea: Remove argument origin_id from call to Loader.send_origin_metadata.
Summary

It no longer needs that argument.

Depends D1603

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 18 2019, 5:15 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2019, 5:15 PM
swh-public-ci added a comment.Jun 18 2019, 5:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/156/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/156/console

Harbormaster failed remote builds in B6302: Diff 5319!Jun 18 2019, 5:17 PM
ardumont edited the summary of this revision. (Show Details)Jun 19 2019, 9:54 AM
ardumont added a subscriber: ardumont.

I just realized the dependency on D1603 for that.
That must be the real reason of the build failure (same goes for the other diff with the extra v in its requirements-swh.txt's version declared on the loader-core).

ardumont added a comment.Jun 19 2019, 10:04 AM

Can you land and tag the loader-core's changes to ensure this build is fine?

I'm waiting for that to validate this.

TIA

swh-public-ci added a comment.Jun 19 2019, 11:35 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/158/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/158/console

swh-public-ci added a comment.Jun 19 2019, 11:42 AM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/159/ for more details.

Harbormaster completed remote builds in B6302: Diff 5319.Jun 19 2019, 11:42 AM
ardumont accepted this revision.Jun 19 2019, 11:45 AM
This revision is now accepted and ready to land.Jun 19 2019, 11:45 AM
Closed by commit rDDEPe03e819599ea: Remove argument origin_id from call to Loader.send_origin_metadata. (authored by vlorentz). · Explain WhyJun 19 2019, 11:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
swh/
deposit/
loader/
3 lines

Diff 5339

View Options

requirements-swh-server.txt

Loading...
View Options

swh/deposit/loader/loader.py

Loading...
About · Developer information · Legal