Page MenuHomeSoftware Heritage
Differential D1568

Add End to end tests: Code Highlighting
ClosedPublic
Actions

Authored by kalpitk on Jun 11 2019, 1:29 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPSb772f85f3289: Add end-to-end tests: highlighting of lines
Summary

Cypress setup with an example test case had been done in D1565.
This diff completes the testing of code highlighting.
Related T1768

Diff Detail

Repository
rDWAPPS Web applications
Branch
js-tests-cypress
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6138
Build 8459: tox-on-jenkinsJenkins
Build 8458: arc lint + arc unit

Event Timeline

kalpitk created this revision.Jun 11 2019, 1:29 PM
Harbormaster failed remote builds in B6138: Diff 5171!Jun 11 2019, 1:29 PM
swh-public-ci added a comment.Jun 11 2019, 1:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/484/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/484/console

kalpitk updated this revision to Diff 5172.Jun 11 2019, 1:32 PM

rebase with master

swh-public-ci added a comment.Jun 11 2019, 1:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/485/ for more details.

Harbormaster completed remote builds in B6139: Diff 5172.Jun 11 2019, 1:36 PM
vlorentz added a subscriber: vlorentz.Jun 11 2019, 1:38 PM

Could you change the name of the commit to be more explicit? (mention that it's for emphasis of line ranges)

kalpitk updated this revision to Diff 5181.Jun 11 2019, 7:27 PM

Update commit message

kalpitk added a project: GSoC 2019.Jun 11 2019, 7:28 PM
kalpitk retitled this revision from Add End to end tests with cypress to Add End to end tests: Code Highlighting.
kalpitk edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Jun 11 2019, 7:31 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/486/ for more details.

Harbormaster completed remote builds in B6149: Diff 5181.Jun 11 2019, 7:31 PM
vlorentz accepted this revision.Jun 12 2019, 11:03 AM
This revision is now accepted and ready to land.Jun 12 2019, 11:03 AM
Closed by commit rDWAPPSb772f85f3289: Add end-to-end tests: highlighting of lines (authored by kalpitk). · Explain WhyJun 12 2019, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
8 lines
4 lines
cypress/
fixtures/
5 lines
integration/
93 lines
plugins/
14 lines
support/
25 lines
24 lines
2 lines
swh/
web/
assets/
config/
6 lines
browse/
views/
2 lines
settings/
25 lines
tests/
15 lines
18 lines
449 lines

Diff 5171

View Options

Makefile.local

Loading...
View Options

cypress.json

Loading...
View Options

cypress/fixtures/example.json

Loading...
View Options

cypress/integration/code-highlighting.spec.js

Loading...
View Options

cypress/plugins/index.js

Loading...
View Options

cypress/support/commands.js

Loading...
View Options

cypress/support/index.js

Loading...
View Options

package.json

Loading...
View Options

swh/web/assets/config/.eslintrc

Loading...
View Options

swh/web/browse/views/origin.py

Loading...
View Options

swh/web/settings/tests.py

Loading...
View Options

swh/web/tests/data.py

Loading...
View Options

swh/web/tests/testcase.py

Loading...
View Options

yarn.lock

Loading...
About · Developer information · Legal