Page MenuHomeSoftware Heritage

swh.lister.core: Remove abstractmethod
ClosedPublic

Authored by nahimilega on Jun 8 2019, 1:28 PM.

Details

Summary

Some of the new listers like GNU and CRAN do not follow the conventional way of making an HTTP request, hence they do not need some of the methods which are usually needed by in conventional HTTP request.

But those methods are marked abstractmethod in the core making them necessary to be present. So it is in best to remove abstractmethod to increase the readability of those listers.

@ardumount stated in D1482 to remove those decorators from the base class as they makes code immediately harder to read and will make it harder to maintain later.

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nahimilega created this revision.Jun 8 2019, 1:28 PM
nahimilega edited the summary of this revision. (Show Details)Jun 8 2019, 1:29 PM
nahimilega added a subscriber: ardumont.
nahimilega edited the summary of this revision. (Show Details)Jun 8 2019, 1:31 PM
nahimilega edited the summary of this revision. (Show Details)
ardumont accepted this revision.EditedJun 8 2019, 5:32 PM

Now, I'd say merge this first in the swh-lister repository.
Then rebase the cran/gnu lister diffs to the latest master branch.

And you shall then be able to remove the unnecessary override methods in those listers.
And then update the diffs.

TIA

Cheers,

This revision is now accepted and ready to land.Jun 8 2019, 5:32 PM
This revision was automatically updated to reflect the committed changes.