Page MenuHomeSoftware Heritage

Refactor the journal client using the new style functions.
ClosedPublic

Authored by vlorentz on Jun 7 2019, 4:15 PM.

Details

Summary

Depends on this swh-journal diff: D1563

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
refactor-journal-client
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6206
Build 8565: tox-on-jenkinsJenkins
Build 8564: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 7 2019, 4:15 PM
vlorentz edited the summary of this revision. (Show Details)Jun 7 2019, 4:24 PM
vlorentz updated this revision to Diff 5152.Jun 7 2019, 4:32 PM

bump dep on swh-journal.

douardda requested changes to this revision.Jun 13 2019, 2:20 PM
douardda added a subscriber: douardda.
douardda added inline comments.
swh/indexer/cli.py
186

What is this new command supposed to do? Shouldn't it come with a usage/description (docstring)? Is journal-client a good name for it?

This revision now requires changes to proceed.Jun 13 2019, 2:20 PM
vlorentz updated this revision to Diff 5232.Jun 14 2019, 10:33 AM

add docstring.

swh/indexer/cli.py
186

I couldn't find a better name. Suggestions welcome.

douardda accepted this revision.Jun 18 2019, 11:50 AM

"bon d'accord !"

This revision is now accepted and ready to land.Jun 18 2019, 11:50 AM
This revision was automatically updated to reflect the committed changes.