Page MenuHomeSoftware Heritage

Refactor the journal client using the new style functions.
ClosedPublic

Authored by vlorentz on Jun 7 2019, 4:15 PM.

Details

Summary

Depends on this swh-journal diff: D1563

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
refactor-journal-client
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6107
Build 8410: tox-on-jenkinsJenkins
Build 8409: arc lint + arc unit

Event Timeline

douardda added a subscriber: douardda.
douardda added inline comments.
swh/indexer/cli.py
185

What is this new command supposed to do? Shouldn't it come with a usage/description (docstring)? Is journal-client a good name for it?

This revision now requires changes to proceed.Jun 13 2019, 2:20 PM

add docstring.

swh/indexer/cli.py
185

I couldn't find a better name. Suggestions welcome.

This revision is now accepted and ready to land.Jun 18 2019, 11:50 AM
This revision was automatically updated to reflect the committed changes.