Page MenuHomeSoftware Heritage

Add a test checking that directory_ls does not recurse into subdirs by default.
ClosedPublic

Authored by vlorentz on Jun 5 2019, 1:33 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
directory_ls-nonrecursive
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6172
Build 8509: tox-on-jenkinsJenkins
Build 8508: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 5 2019, 1:33 PM
douardda accepted this revision.Jun 12 2019, 12:24 PM
douardda added a subscriber: douardda.

It's not that straightforward that this test does indeed do what the commit message pretends... A comment or 2 in the code of the test would not hurt. But meh

This revision is now accepted and ready to land.Jun 12 2019, 12:24 PM
vlorentz updated this revision to Diff 5199.Jun 12 2019, 3:44 PM
  • rebase
  • add comments

It's not that straightforward that this test does indeed do what the commit message pretends...

It's clearer when you compare with the code of test above

This revision was automatically updated to reflect the committed changes.