Page MenuHomeSoftware Heritage

Unify argument names of the pg and in-mem storage.
ClosedPublic

Authored by vlorentz on May 29 2019, 3:03 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
unify-arg-names
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5961
Build 8174: tox-on-jenkinsJenkins
Build 8173: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 29 2019, 3:03 PM
vlorentz updated this revision to Diff 5023.May 29 2019, 6:13 PM
  • fix names
olasd accepted this revision.Jun 4 2019, 9:29 AM
olasd added a subscriber: olasd.

Some part of me wonders if it wouldn't make sense to unify the other way around, as the argument names you picked in the in-memory storage are way more sensible, but we've not succeeded in making a change in this area without breaking some (or all) clients...

This revision is now accepted and ready to land.Jun 4 2019, 9:29 AM
This revision was automatically updated to reflect the committed changes.