Related T1477
Update of Deposit Admin Table is pending.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS135360c835c4: Make DataTables Responsive
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/452/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/453/ for more details.
Comment Actions
Nice improvements but that diff is not landable as is (see my inline comments).
Also, you should handle the responsive layout for the tables in the admin interface and the one listing api endpoints.
| package.json | ||
|---|---|---|
| 23 | you can remove that dependency | |
| swh/web/assets/src/bundles/vendors/index.js | ||
| 29 | you can remove this import | |
| swh/web/templates/includes/directory-display.html | ||
| 54–67 | I would prefer the approach of hiding the mode and size columns according to the screen size instead of duplicating some template code here. Plus the icon for directories is not the right one and the icon colors are not the same for small screens. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/457/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/458/ for more details.
Comment Actions
Only admin deposit table is left. I am not sure about what priority order should I keep for the columns.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/466/ for more details.
Comment Actions
Still some improvements to bring.
After reading the documentation of responsive DataTables, I think the responsive settings
(including columns priority) should be added directly in the HTML templates instead of using Javascript.
In the files templates/browse/origin-save.html and templates/admin/origin-save.html, can you rename the table headers to the following:
- Request date -> Date
- Origin type -> Type
- Origin url -> Url
- Request status -> Request
- Save task status -> Status
This will make the headers look nicer on small screen devices.
Plus some inline comments to process.
| swh/web/assets/src/bundles/vendors/index.js | ||
|---|---|---|
| 30–31 | You need to explicitly import the responsive CSS after the base bs4 one using: import 'datatables.net-responsive-bs4/css/responsive.bootstrap4.css'; Otherwise, webpack will not process it and the responsive stylesheets will not be part of the produced CSS bundles. | |
| swh/web/templates/api/endpoints.html | ||
| 51–52 | Can you remove the Status column here ? There is no more interest to keep it today. | |
| swh/web/templates/includes/directory-display.html | ||
| 16–17 | We should hide the Size column too on small screens | |
Comment Actions
@anlambert made all the changes.
| swh/web/templates/includes/directory-display.html | ||
|---|---|---|
| 16–17 | with the new commit hiding on xs screens. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/468/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/470/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/471/ for more details.