Differential D1512

Exempt DINSIC from swh-web rate limiting
ClosedPublic
Actions

Authored by anlambert on May 24 2019, 11:52 AM.

Tags

None

Subscribers

Details

Reviewers

ardumont
olasd

Commits

rSPSITE946372ba41c9: data/defaults.yaml: Exempt DINSIC from swh-web api rate limiting

Summary

Add a new exempted IP from swh-web rate limiting.

Related T1746

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 24 2019, 11:52 AM

Harbormaster completed remote builds in B5913: Diff 4966.May 24 2019, 11:52 AM

Update commit message: s/leading/trailing/

Harbormaster completed remote builds in B5914: Diff 4967.May 24 2019, 11:59 AM

anlambert edited the summary of this revision. (Show Details)May 24 2019, 12:00 PM

AntoineAugusti added a subscriber: AntoineAugusti.May 24 2019, 12:04 PM

zack requested changes to this revision.May 24 2019, 12:26 PM

zack added a subscriber: zack.

zack added inline comments.

data/defaults.yaml
1720	DINSIC only needs to check which origins we have, among those of interest to them (sorry, I should've clarified this in T1746), so we only need this part of the diff, and not the other two (vault and save origin). (Principle of least privileges and all that. :-))

This revision now requires changes to proceed.May 24 2019, 12:26 PM

Update: Exempt DINSIC only from the web api rate limit

Harbormaster completed remote builds in B5916: Diff 4968.May 24 2019, 12:30 PM

ardumont accepted this revision.May 27 2019, 10:01 AM

Update: trailing whitespaces are important for PGP keys so do not remove them

Harbormaster completed remote builds in B5933: Diff 4983.May 27 2019, 11:45 AM

Update: Remove the commit related to trailing whitespaces

Harbormaster completed remote builds in B5946: Diff 4997.May 28 2019, 2:39 PM

anlambert edited the summary of this revision. (Show Details)May 28 2019, 2:40 PM

olasd accepted this revision.May 28 2019, 2:45 PM

Rebase

Harbormaster completed remote builds in B5948: Diff 4999.May 28 2019, 2:47 PM

olasd accepted this revision.May 28 2019, 2:47 PM

olasd removed a reviewer: zack.

This revision is now accepted and ready to land.May 28 2019, 2:48 PM

Closed by commit rSPSITE946372ba41c9: data/defaults.yaml: Exempt DINSIC from swh-web api rate limiting (authored by anlambert). · Explain WhyMay 28 2019, 2:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

data/

2 lines

Diff 5000

data/defaults.yaml

Loading...