Paths

Table of Contentst

Differential D1510

Decrease beta ribbon size and hide donate button for small screens
ClosedPublic
Actions

Authored by kalpitk on May 23 2019, 7:16 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS737948de0803: Hide donate button for small screens
rDWAPPS290a95d1b39e: Decrease beta ribbon size for small screens

Summary

Since beta ribbon obstructed view of various pages, its size is decreased.
Donate button overlaps with other links, thus it was hidden on small screens.
Related T1477

Diff Detail

Repository

rDWAPPS Web applications

Branch

betaRibbon

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5905
Build 8090: tox-on-jenkins	Jenkins
Build 8089: arc lint + arc unit

Event Timeline

kalpitk created this revision.May 23 2019, 7:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 23 2019, 7:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/448/ for more details.

Harbormaster completed remote builds in B5905: Diff 4959.May 23 2019, 7:20 PM

kalpitk mentioned this in D1505: Hide beta ribbon for non-large screens.May 23 2019, 7:20 PM

kalpitk edited the summary of this revision. (Show Details)

kalpitk added a subscriber: anlambert.

Great, this looks better indeed. Please rebase your changes on origin/master and I will accept that diff.

Decrease beta ribbon size for small screens
Hide donate button for small screens

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/449/ for more details.

Harbormaster completed remote builds in B5906: Diff 4960.May 23 2019, 7:34 PM

Looks good to me, you can land it.

This revision is now accepted and ready to land.May 23 2019, 8:49 PM

Closed by commit rDWAPPS290a95d1b39e: Decrease beta ribbon size for small screens (authored by kalpitk). · Explain WhyMay 24 2019, 9:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

assets/

src/

bundles/

browse/

browse.css

8 lines

webapp/

webapp.css

4 lines

Diff 4959

View Options

swh/web/assets/src/bundles/browse/browse.css