Page MenuHomeSoftware Heritage

Simplify extra dependency setup for azure nodes
ClosedPublic

Authored by ardumont on May 22 2019, 1:32 PM.

Details

Summary

Azure nodes needs the extra python3-swh.objstorage.cloud package (workers, vault).

So, defines the extra python3-swh.objstorage.cloud as a package dependency on azure_euwest location nodes.

As this is rendering some extra objstorage_cloud class obsolete (it was a temporary hack IIRC), this is the right time to clean up a bit.

Test Plan

Action -> Expectation/goal

bin/octocatalog-diff saatchi -> nothing to do (nodes on rocq)
bin/octocatalog-diff vault -> wants to install the missing dependency python3-swh.objstorage.cloud
bin/octocatalog-diff worker01.euwest.azure -> nothing to do (package already installed there)

Diff Detail

Repository
rSPSITE puppet-swh-site
Branch
production
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5883
Build 8060: arc lint + arc unit

Event Timeline

ardumont created this revision.May 22 2019, 1:32 PM
ardumont edited the summary of this revision. (Show Details)May 22 2019, 1:58 PM
ardumont retitled this revision from apt_config: Add extra package installation option to Simplify extra dependency setup for azure nodes.May 22 2019, 2:16 PM

As suggested by @olasd, using the packages: variable will do just fine.
So no need for adding yet an extra variable.

I'm currently checking the simpler implementation still does the job and will update the diff.

ardumont updated this revision to Diff 4940.EditedMay 22 2019, 2:19 PM
ardumont edited the summary of this revision. (Show Details)

Simplify implementation using the existing code

ardumont edited the summary of this revision. (Show Details)May 22 2019, 2:21 PM
ardumont added a project: Puppet recipes.
ardumont edited the summary of this revision. (Show Details)May 22 2019, 2:38 PM
ardumont updated this revision to Diff 4943.May 22 2019, 2:44 PM

Rebase on latest production branch and plug diff to branch

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2019, 2:45 PM
This revision was automatically updated to reflect the committed changes.