Page MenuHomeSoftware Heritage
Differential D1477

cli: add a 'storage' cli group with a 'serve' subcommand
ClosedPublic
Actions

Authored by douardda on May 15 2019, 5:13 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOCfa02fa4d41dc: cli: add a 'storage' cli group with a 'rpc-serve' subcommand
rDSTOfa02fa4d41dc: cli: add a 'storage' cli group with a 'rpc-serve' subcommand
Summary

we do add this 'storage' group even if it contains only one subcommand
(serve) for UI consistency:

swh storage server

is a more understandable command than just 'swh storage' to start the
http server.

We do keep the main swh-storage console_script entry point as is for
bw compat, however.

Related to T1671.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 15 2019, 5:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 15 2019, 5:13 PM
swh-public-ci added a comment.May 15 2019, 5:19 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/382/ for more details.

Harbormaster completed remote builds in B5733: Diff 4833.May 15 2019, 5:19 PM
ardumont accepted this revision.May 16 2019, 4:20 PM
This revision is now accepted and ready to land.May 16 2019, 4:20 PM
douardda updated this revision to Diff 4855.May 16 2019, 5:05 PM

rename the 'serve' subcommand as 'rpc-serve'

swh-public-ci added a comment.May 16 2019, 5:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/387/ for more details.

Harbormaster completed remote builds in B5761: Diff 4855.May 16 2019, 5:11 PM
douardda updated this revision to Diff 4856.May 16 2019, 5:29 PM

rebased

This revision was landed with ongoing or failed builds.May 16 2019, 5:29 PM
Closed by commit rDSTOfa02fa4d41dc: cli: add a 'storage' cli group with a 'rpc-serve' subcommand (authored by douardda). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B5762: Diff 4856!May 16 2019, 5:40 PM
swh-public-ci added a comment.May 16 2019, 5:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/420/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/420/console

Revision Contents
Changeset List

PathSize
2 lines
swh/
storage/
25 lines

Diff 4857

View Options

setup.py

Loading...
View Options

swh/storage/cli.py

Loading...
About · Developer information · Legal