Differential D1434

Prevent from_dict() from changing its input dict.
ClosedPublic
Actions

Authored by vlorentz on Apr 26 2019, 1:33 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDMODfc3d3c1c7e3e: Prevent from_dict() from changing its input dict.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 26 2019, 1:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 26 2019, 1:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/70/ for more details.

Harbormaster completed remote builds in B5543: Diff 4662.Apr 26 2019, 1:34 PM

Looks good to me.

This revision is now accepted and ready to land.Apr 26 2019, 1:36 PM

Closed by commit rDMODfc3d3c1c7e3e: Prevent from_dict() from changing its input dict. (authored by vlorentz). · Explain WhyApr 26 2019, 1:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

model/

model.py

24 lines

tests/

test_model.py

14 lines

Diff 4663

View Options

swh/model/model.py