Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDMODefc7e725991a: Add a from_dict() method to model classes, that does the inverse of to_dict().
Diff Detail
- Repository
- rDMOD Data model
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/64/ for more details.
swh/model/model.py | ||
---|---|---|
33 | I'm a bit puzzled by the fact the commit message says:
so I read it like "to_dict already exists"... which looks like it is not the case, at least not everywhere. Maybe a better commit message? Also this needs to be documented since it's now part of the api of the model, so it also needs docstrings. |
More doc.
swh/model/model.py | ||
---|---|---|
33 |
It did exist, but was missing from some classes where is was not necessary. |
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/68/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/69/ for more details.