Page MenuHomeSoftware Heritage
Differential D1377

Fix support of releases with no author or date.
ClosedPublic
Actions

Authored by vlorentz on Apr 9 2019, 4:12 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSTOC95c0b279efc7: Fix support of releases with no author or date.
rDSTO95c0b279efc7: Fix support of releases with no author or date.
Summary

Bug found by Hypothesis.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 9 2019, 4:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 9 2019, 4:12 PM
swh-public-ci added a comment.Apr 9 2019, 4:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/328/ for more details.

Harbormaster completed remote builds in B5234: Diff 4426.Apr 9 2019, 4:32 PM
olasd accepted this revision.Apr 9 2019, 4:36 PM
olasd added a subscriber: olasd.

We'll need to bundle up the last few schema changes into an upgrade script once we're done with all of these.

swh/storage/sql/40-swh-func.sql
670

The fullname is not null clause can probably move to the CTE which will make things somewhat clearer.

This revision is now accepted and ready to land.Apr 9 2019, 4:36 PM
vlorentz added a child revision: D1383: Add a test that adds arbitrary objects to the storage..Apr 9 2019, 4:44 PM
vlorentz updated this revision to Diff 4439.Apr 9 2019, 4:57 PM

Apply @olasd's comment.

swh-public-ci added a comment.Apr 9 2019, 5:17 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/336/ for more details.

Harbormaster completed remote builds in B5247: Diff 4439.Apr 9 2019, 5:17 PM
vlorentz updated this revision to Diff 4450.Apr 9 2019, 5:23 PM
  • rebase
vlorentz updated this revision to Diff 4451.Apr 9 2019, 5:24 PM
  • rebase
This revision was landed with ongoing or failed builds.Apr 9 2019, 5:24 PM
Closed by commit rDSTO95c0b279efc7: Fix support of releases with no author or date. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B5258: Diff 4450!Apr 9 2019, 5:29 PM
swh-public-ci added a comment.Apr 9 2019, 5:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/344/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/344/console

Harbormaster failed remote builds in B5259: Diff 4451!Apr 9 2019, 5:30 PM
swh-public-ci added a comment.Apr 9 2019, 5:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/345/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/345/console

Revision Contents
Changeset List

PathSize
swh/
storage/
3 lines
sql/
1 line
tests/
14 lines

Diff 4452

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/sql/40-swh-func.sql

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal