Page MenuHomeSoftware Heritage
Differential D1325

Use sha1 instead of bigint as FK from origin_visit to snapshot (part 2: backfill + start using the new colum for reading + cleanup)
ClosedPublic
Actions

Authored by vlorentz on Apr 1 2019, 11:58 AM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSTOC1ddb1453605e: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 3: cleanup)
rDSTOC7b56701b64d5: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 2…
R65:1ddb1453605e: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 3: cleanup)
R65:7b56701b64d5: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 2…
rDSTO1ddb1453605e: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 3: cleanup)
rDSTO7b56701b64d5: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 2…
Summary

Migration order: run 132.sql then update the storage API then run 133.sql

Diff Detail

Repository
rDSTO Storage manager
Branch
snapshot_fk_2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4988
Build 6684: tox-on-jenkinsJenkins
Build 6683: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 1 2019, 11:58 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 1 2019, 11:58 AM
vlorentz added a reviewer: olasd.Apr 1 2019, 11:59 AM
Harbormaster failed remote builds in B4967: Diff 4204!Apr 1 2019, 11:59 AM
swh-public-ci added a comment.Apr 1 2019, 11:59 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/247/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/247/console

vlorentz updated this revision to Diff 4205.Apr 1 2019, 12:01 PM
  • Add missing part of the commit
vlorentz added a parent revision: D1324: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 1: add new column).Apr 1 2019, 12:01 PM
vlorentz updated this revision to Diff 4206.EditedApr 1 2019, 12:02 PM

Drop swh_snapshot_get_by_origin_visit from 40-swh-func.sql as well.

swh-public-ci added a comment.Apr 1 2019, 12:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/248/ for more details.

Harbormaster completed remote builds in B4968: Diff 4205.Apr 1 2019, 12:06 PM
swh-public-ci added a comment.Apr 1 2019, 12:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/249/ for more details.

Harbormaster completed remote builds in B4969: Diff 4206.Apr 1 2019, 12:10 PM
vlorentz updated this revision to Diff 4208.Apr 1 2019, 1:20 PM

Rebase

Harbormaster failed remote builds in B4971: Diff 4208!Apr 1 2019, 1:20 PM
swh-public-ci added a comment.Apr 1 2019, 1:20 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/251/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/251/console

vlorentz updated this revision to Diff 4210.Apr 1 2019, 1:21 PM

rebase

vlorentz updated this revision to Diff 4211.Apr 1 2019, 1:22 PM

Fix initial DB schema.

vlorentz updated this revision to Diff 4212.Apr 1 2019, 1:29 PM

Fix initial DB schema (again).

swh-public-ci added a comment.Apr 1 2019, 1:31 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/253/ for more details.

Harbormaster completed remote builds in B4973: Diff 4210.Apr 1 2019, 1:31 PM
swh-public-ci added a comment.Apr 1 2019, 1:34 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/254/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/254/console

Harbormaster failed remote builds in B4974: Diff 4211!Apr 1 2019, 1:34 PM
swh-public-ci added a comment.Apr 1 2019, 1:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/255/ for more details.

Harbormaster completed remote builds in B4975: Diff 4212.Apr 1 2019, 1:40 PM
vlorentz updated this revision to Diff 4213.Apr 1 2019, 1:59 PM

Remove dangling 'validate' statement.

swh-public-ci added a comment.Apr 1 2019, 2:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/256/ for more details.

Harbormaster completed remote builds in B4976: Diff 4213.Apr 1 2019, 2:06 PM
vlorentz updated this revision to Diff 4214.Apr 1 2019, 2:18 PM

Add test.

swh-public-ci added a comment.Apr 1 2019, 2:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/257/ for more details.

Harbormaster completed remote builds in B4977: Diff 4214.Apr 1 2019, 2:24 PM
vlorentz updated this revision to Diff 4221.Apr 1 2019, 3:19 PM

rebase

vlorentz updated this revision to Diff 4222.Apr 1 2019, 3:20 PM

Update dbversion in migration 132.

vlorentz updated this revision to Diff 4223.Apr 1 2019, 3:21 PM

Fix commit

swh-public-ci added a comment.Apr 1 2019, 3:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/259/ for more details.

Harbormaster completed remote builds in B4987: Diff 4221.Apr 1 2019, 3:24 PM
swh-public-ci added a comment.Apr 1 2019, 3:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/260/ for more details.

Harbormaster completed remote builds in B4988: Diff 4222.Apr 1 2019, 3:30 PM
swh-public-ci added a comment.Apr 1 2019, 3:35 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/261/ for more details.

Harbormaster completed remote builds in B4989: Diff 4223.Apr 1 2019, 3:35 PM
vlorentz added a child revision: D1327: Make snapshot_add take an iterable of snapshot..Apr 1 2019, 4:13 PM
vlorentz added a child revision: D1329: Make snapshot_add take an iterable of snapshot..Apr 1 2019, 4:23 PM
olasd accepted this revision.Apr 1 2019, 5:45 PM
This revision is now accepted and ready to land.Apr 1 2019, 5:45 PM
Closed by commit rDSTO7b56701b64d5: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 2… (authored by vlorentz). · Explain WhyApr 1 2019, 5:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sql/
upgrades/
12 lines
12 lines
swh/
storage/
32 lines
sql/
4 lines
12 lines
3 lines
tests/
75 lines

Diff 4222

View Options

sql/upgrades/132.sql

Loading...
View Options

sql/upgrades/133.sql

Loading...
View Options

swh/storage/db.py

Loading...
View Options

swh/storage/sql/30-swh-schema.sql

Loading...
View Options

swh/storage/sql/40-swh-func.sql

Loading...
View Options

swh/storage/sql/60-swh-indexes.sql

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal