Differential D1307

Make assert_publish_ok use 'assert ... = expected' instead of a complicated for loop.
ClosedPublic
Actions

Authored by vlorentz on Mar 27 2019, 1:44 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNLdee00e7944a2: Make assert_publish_ok use 'assert ... = expected' instead of a complicated for…

Summary

Depends on D1306.

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

improve-test_publisher_kafka

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4873
Build 6504: tox-on-jenkins	Jenkins
Build 6503: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 27 2019, 1:44 PM

Harbormaster failed remote builds in B4873: Diff 4121!Mar 27 2019, 1:45 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/66/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/66/console

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/67/ for more details.

ardumont accepted this revision.Mar 27 2019, 2:46 PM

This revision is now accepted and ready to land.Mar 27 2019, 2:46 PM

This revision was landed with ongoing or failed builds.Mar 27 2019, 2:46 PM

Closed by commit rDJNLdee00e7944a2: Make assert_publish_ok use 'assert ... = expected' instead of a complicated for… (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

test_publisher_kafka.py

23 lines

Diff 4121

View Options

swh/journal/tests/test_publisher_kafka.py

Make assert_publish_ok use 'assert ... = expected' instead of a complicated for loop.ClosedPublicActions