Page MenuHomeSoftware Heritage
Differential D1282

Make swh-journal node run on swh-kafka node
ClosedPublic
Actions

Authored by ardumont on Mar 20 2019, 12:39 PM.

Details

Reviewers
douardda
olasd
Group Reviewers
Reviewers
Commits
rCJSWH43d4b34a59d8: Make swh-journal project run on swh-kafka docker image
Summary

Let other unit tests run as usual on the default swh-tox image.

Related T1276
Related D1239
Depends on D1280

Test Plan
$ pip install jenkins-job-builder
$ tox

At the moment, that does not work
The plan is something like this:

$ tox > before
$ grep assignedNode before | grep swh-kafka
$ arc patch <this>
$ tox > now
$ grep assignedNode now | grep swh-kafka
<assignedNode>swh-kafka</assignedNode>

Diff Detail

Repository
rCJSWH Jenkins jobs
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4761
Build 6343: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 20 2019, 12:39 PM
Harbormaster completed remote builds in B4754: Diff 4032.Mar 20 2019, 12:39 PM
olasd accepted this revision.Mar 20 2019, 1:58 PM
This revision is now accepted and ready to land.Mar 20 2019, 1:58 PM
ardumont mentioned this in D1239: swh-journal: Add tests to the journal publisher using kafka instance.Mar 20 2019, 2:06 PM
ardumont added a child revision: D1239: swh-journal: Add tests to the journal publisher using kafka instance.Mar 20 2019, 2:11 PM
ardumont updated this revision to Diff 4037.Mar 20 2019, 3:54 PM

Something simpler where tox actually run

I did:

pip install jenkins-job-builder
tox
Harbormaster completed remote builds in B4759: Diff 4037.Mar 20 2019, 3:54 PM
ardumont planned changes to this revision.Mar 20 2019, 4:08 PM
ardumont edited the test plan for this revision. (Show Details)Mar 20 2019, 4:36 PM
ardumont updated this revision to Diff 4038.Mar 20 2019, 5:31 PM
ardumont edited the test plan for this revision. (Show Details)

Make the diff actually as the test plan mention \m/

This revision is now accepted and ready to land.Mar 20 2019, 5:31 PM
Harbormaster completed remote builds in B4760: Diff 4038.Mar 20 2019, 5:32 PM
ardumont edited the summary of this revision. (Show Details)Mar 20 2019, 6:44 PM
ardumont updated this revision to Diff 4040.Mar 20 2019, 6:49 PM

Simpler implementation based on olasd's help

http://paste.debian.net/1073977/

Harbormaster completed remote builds in B4761: Diff 4040.Mar 20 2019, 6:49 PM
olasd accepted this revision.Mar 20 2019, 6:50 PM
ardumont updated this revision to Diff 4041.Mar 20 2019, 6:53 PM

Use docker-image term as it's clearer

Also rework the git message

Harbormaster completed remote builds in B4762: Diff 4041.Mar 20 2019, 6:53 PM
Closed by commit rCJSWH43d4b34a59d8: Make swh-journal project run on swh-kafka docker image (authored by ardumont). · Explain WhyMar 20 2019, 6:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
jobs/
1 line
templates/
3 lines

Diff 4040

View Options

jobs/swh-packages.yaml

Loading...
View Options

jobs/templates/swh-tox.yaml

Loading...
About · Developer information · Legal