Page MenuHomeSoftware Heritage
Differential D1206

Prevent origin metadata indexer from writing empty records
ClosedPublic
Actions

Authored by vlorentz on Feb 27 2019, 3:44 PM.

Details

Reviewers
anlambert
zack
Group Reviewers
Reviewers
Maniphest Tasks
T1549: Clean up entries in {origin_intrinsic,revision}_metadata with no metadata
Commits
rDCIDX3b537e3902db: Prevent origin metadata indexer from writing empty records
Summary

Depends on D1205.
Resolves T1549.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
empty-metadata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4497
Build 5966: tox-on-jenkinsJenkins
Build 5965: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 27 2019, 3:44 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 27 2019, 3:44 PM
Harbormaster failed remote builds in B4475: Diff 3781!Feb 27 2019, 3:44 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 27 2019, 3:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/471/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/471/console

anlambert accepted this revision.Feb 28 2019, 1:31 PM
This revision is now accepted and ready to land.Feb 28 2019, 1:31 PM
vlorentz updated this revision to Diff 3803.Feb 28 2019, 4:59 PM
  • rebase
  • adapt
vlorentz requested review of this revision.Feb 28 2019, 4:59 PM
Harbormaster failed remote builds in B4497: Diff 3803!Feb 28 2019, 5:02 PM
swh-public-ci added a comment.Feb 28 2019, 5:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/476/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/476/console

vlorentz updated this revision to Diff 3814.Mar 1 2019, 10:49 AM
  • rebase
zack accepted this revision.Mar 1 2019, 10:51 AM
zack added a subscriber: zack.

LGTM, please just add a comment on the test case (as discussed in the review) before landing

swh/indexer/metadata.py
304

a comment here explaining that we do not want to store "empty" mappings in this case would be nice

(feel free to amend/land this directly, no need for an extra review round-trip)

This revision is now accepted and ready to land.Mar 1 2019, 10:51 AM
swh-public-ci added a comment.Mar 1 2019, 10:52 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/479/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/479/console

Harbormaster failed remote builds in B4511: Diff 3814!Mar 1 2019, 10:52 AM
vlorentz updated this revision to Diff 3815.Mar 1 2019, 10:57 AM
  • explain why we filter out empty mapping lists.
swh-public-ci added a comment.Mar 1 2019, 10:59 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/480/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/480/console

Harbormaster failed remote builds in B4512: Diff 3815!Mar 1 2019, 10:59 AM
vlorentz updated this revision to Diff 3816.Mar 1 2019, 11:00 AM

re-apply change that was lost in the rebasing dance

swh-public-ci added a comment.Mar 1 2019, 11:03 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/481/ for more details.

Harbormaster completed remote builds in B4513: Diff 3816.Mar 1 2019, 11:03 AM
Closed by commit rDCIDX3b537e3902db: Prevent origin metadata indexer from writing empty records (authored by vlorentz). · Explain WhyMar 1 2019, 11:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
indexer/
43 lines
tests/
53 lines

Diff 3803

View Options

swh/indexer/metadata.py

Loading...
View Options

swh/indexer/tests/test_origin_metadata.py

Loading...
About · Developer information · Legal