Page MenuHomeSoftware Heritage
Differential D1205

Add API to delete metadata entries.
ClosedPublic
Actions

Authored by vlorentz on Feb 27 2019, 3:40 PM.

Details

Reviewers
anlambert
zack
Group Reviewers
Reviewers
Commits
rDCIDXc581ad96d692: Add API to delete metadata entries.
Summary

T1549

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 27 2019, 3:40 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 27 2019, 3:40 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 27 2019, 3:43 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/470/ for more details.

Harbormaster completed remote builds in B4474: Diff 3780.Feb 27 2019, 3:43 PM
vlorentz added a child revision: D1206: Prevent origin metadata indexer from writing empty records.Feb 27 2019, 3:44 PM
vlorentz updated this revision to Diff 3782.Feb 27 2019, 3:46 PM
  • Fix docstrings.
swh-public-ci added a comment.Feb 27 2019, 3:49 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/472/ for more details.

Harbormaster completed remote builds in B4476: Diff 3782.Feb 27 2019, 3:49 PM
anlambert accepted this revision.Feb 28 2019, 12:31 PM
anlambert added a subscriber: anlambert.

Looks good to me

swh/indexer/storage/__init__.py
668

missing argument types information in docstring here and below

This revision is now accepted and ready to land.Feb 28 2019, 12:31 PM
vlorentz updated this revision to Diff 3801.Feb 28 2019, 4:52 PM
  • Make origin_intrinsinc_metadata_delete and revision_metadata_delete take a list of items instead of a single item.
swh-public-ci added a comment.Feb 28 2019, 4:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/474/ for more details.

Harbormaster completed remote builds in B4495: Diff 3801.Feb 28 2019, 4:55 PM
vlorentz updated this revision to Diff 3802.Feb 28 2019, 4:58 PM
  • Fix name.
vlorentz requested review of this revision.Feb 28 2019, 4:59 PM
vlorentz marked an inline comment as done.
swh-public-ci added a comment.Feb 28 2019, 5:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/475/ for more details.

Harbormaster completed remote builds in B4496: Diff 3802.Feb 28 2019, 5:01 PM
zack accepted this revision.Mar 1 2019, 10:46 AM
zack added a subscriber: zack.

LGTM

This revision is now accepted and ready to land.Mar 1 2019, 10:46 AM
vlorentz updated this revision to Diff 3812.Mar 1 2019, 10:48 AM
  • rebase
Closed by commit rDCIDXc581ad96d692: Add API to delete metadata entries. (authored by vlorentz). · Explain WhyMar 1 2019, 10:48 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B4509: Diff 3812!Mar 1 2019, 10:49 AM
swh-public-ci added a comment.Mar 1 2019, 10:49 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/478/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/478/console

Revision Contents
Changeset List

PathSize
swh/
indexer/
storage/
27 lines
20 lines
35 lines
tests/
storage/
99 lines

Diff 3813

View Options

swh/indexer/storage/__init__.py

Loading...
View Options

swh/indexer/storage/db.py

Loading...
View Options

swh/indexer/storage/in_memory.py

Loading...
View Options

swh/indexer/tests/storage/test_storage.py

Loading...
About · Developer information · Legal