Page MenuHomeSoftware Heritage
Differential D1150

Add idx storage endpoint to search metadata by mapping.
ClosedPublic
Actions

Authored by vlorentz on Feb 18 2019, 2:07 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1529: Efficient reindex when updating a metadata mapping
Commits
rDCIDX6344edac9941: Add storage endpoint to search metadata by mapping.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
origin_intrinsic_metadata_search_by_producer
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4353
Build 5752: tox-on-jenkinsJenkins
Build 5751: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 18 2019, 2:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 18 2019, 2:07 PM
Harbormaster failed remote builds in B4275: Diff 3622!Feb 18 2019, 2:07 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 18 2019, 2:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/433/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/433/console

vlorentz updated this revision to Diff 3623.Feb 18 2019, 2:08 PM
  • bump db schema version
Harbormaster failed remote builds in B4276: Diff 3623!Feb 18 2019, 2:08 PM
swh-public-ci added a comment.Feb 18 2019, 2:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/434/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/434/console

vlorentz added a task: T1529: Efficient reindex when updating a metadata mapping.Feb 18 2019, 2:27 PM
vlorentz edited the summary of this revision. (Show Details)
vlorentz edited the summary of this revision. (Show Details)
vlorentz updated this revision to Diff 3650.Feb 20 2019, 11:26 AM
vlorentz added a child revision: D1157: Add support for filtering by tool_id to origin_intrinsic_metadata_search_by_producer..
  • rebase
swh-public-ci added a comment.Feb 20 2019, 11:29 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/440/ for more details.

Harbormaster completed remote builds in B4327: Diff 3650.Feb 20 2019, 11:29 AM
ardumont accepted this revision.Feb 20 2019, 6:07 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/indexer/storage/db.py
351

why the change here?

This revision is now accepted and ready to land.Feb 20 2019, 6:07 PM
vlorentz marked an inline comment as done.Feb 21 2019, 9:51 AM
vlorentz added inline comments.
swh/indexer/storage/db.py
351

No particular reason; it's just that I noticed this method will crash if cur=None.

vlorentz updated this revision to Diff 3674.Feb 21 2019, 9:54 AM

rebase

Closed by commit rDCIDX6344edac9941: Add storage endpoint to search metadata by mapping. (authored by vlorentz). · Explain WhyFeb 21 2019, 9:54 AM
This revision was automatically updated to reflect the committed changes.
swh-public-ci added a comment.Feb 21 2019, 9:57 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/444/ for more details.

Harbormaster completed remote builds in B4353: Diff 3674.Feb 21 2019, 9:57 AM

Revision Contents
Changeset List

PathSize
sql/
upgrades/
9 lines
swh/
indexer/
sql/
2 lines
1 line
storage/
38 lines
39 lines
44 lines
tests/
storage/
69 lines

Diff 3674

View Options

sql/upgrades/122.sql

Loading...
View Options

swh/indexer/sql/30-swh-schema.sql

Loading...
View Options

swh/indexer/sql/60-swh-indexes.sql

Loading...
View Options

swh/indexer/storage/__init__.py

Loading...
View Options

swh/indexer/storage/db.py

Loading...
View Options

swh/indexer/storage/in_memory.py

Loading...
View Options

swh/indexer/tests/storage/test_storage.py

Loading...
About · Developer information · Legal