Page MenuHomeSoftware Heritage

Move job_exists to an external library
ClosedPublic

Authored by olasd on Feb 7 2019, 7:28 PM.

Details

Summary

This avoids very red script security warnings and also allows to use the
jobExists function in other jobs.

Test Plan

Doesn't break Jenkins (once the settings are correct)

Diff Detail

Repository
rCJSWH Jenkins jobs
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4096
Build 5390: arc lint + arc unit

Event Timeline

olasd created this revision.Feb 7 2019, 7:28 PM
ardumont accepted this revision.Feb 7 2019, 7:45 PM
ardumont added a subscriber: ardumont.

sounds good

from where does the jobExists function come from though? (is that coming from some jenkins setup for example).

This revision is now accepted and ready to land.Feb 7 2019, 7:45 PM
olasd added a comment.Feb 7 2019, 8:37 PM

sounds good
from where does the jobExists function come from though? (is that coming from some jenkins setup for example).

It's coming from the https://forge.softwareheritage.org/source/swh-jenkins-library/ repo.

If we have other groovy functions to stash away we can put them there. Jenkins is configured to pull this repo as a library.

For instance, a bunch of Phabricator-related functions could move there

thanks for the information.

This revision was automatically updated to reflect the committed changes.