Page MenuHomeSoftware Heritage
Differential D1081

Prevent OriginMetadataIndexer from sending duplicate revisions to revision_metadata_add.
ClosedPublic
Actions

Authored by vlorentz on Feb 5 2019, 12:04 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDX9657abaf20a2: Prevent OriginMetadataIndexer from sending duplicate revisions to…
Summary

Depends on D1080.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
origin-meta-idx-duplicates2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4162
Build 5486: tox-on-jenkinsJenkins
Build 5485: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 5 2019, 12:04 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 5 2019, 12:04 PM
Harbormaster failed remote builds in B4014: Diff 3394!Feb 5 2019, 12:06 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 5 2019, 12:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/317/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/317/console

ardumont accepted this revision.Feb 6 2019, 3:15 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/indexer/metadata.py
311

why not build the 2 lists (rev_metadata, orig_metadata) in one go since you iterate over it here already?

This revision is now accepted and ready to land.Feb 6 2019, 3:15 PM
vlorentz updated this revision to Diff 3422.Feb 6 2019, 5:06 PM
  • Simplify code
Harbormaster failed remote builds in B4050: Diff 3422!Feb 6 2019, 5:06 PM
swh-public-ci added a comment.Feb 6 2019, 5:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/324/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/324/console

vlorentz updated this revision to Diff 3423.Feb 6 2019, 5:07 PM
vlorentz marked 2 inline comments as done.
  • Fix
Harbormaster failed remote builds in B4051: Diff 3423!Feb 6 2019, 5:07 PM
vlorentz added inline comments.Feb 6 2019, 5:07 PM
swh/indexer/metadata.py
311

Good catch

swh-public-ci added a comment.Feb 6 2019, 5:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/325/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/325/console

vlorentz added a parent revision: D1106: Move boilerplate out of test_origin_metadata_indexer so it's reusable by other tests..Feb 8 2019, 11:58 AM
vlorentz removed a parent revision: D1080: Restructure origin_metadata_indexer_test to make it easier to add more origin metadata idx tests..
vlorentz updated this revision to Diff 3480.Feb 8 2019, 12:02 PM
vlorentz added a parent revision: D1080: Restructure origin_metadata_indexer_test to make it easier to add more origin metadata idx tests..
Harbormaster failed remote builds in B4109: Diff 3480!Feb 8 2019, 12:03 PM
swh-public-ci added a comment.Feb 8 2019, 12:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/376/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/376/console

vlorentz updated this revision to Diff 3526.Feb 12 2019, 12:15 PM
  • rebase
swh-public-ci added a comment.Feb 12 2019, 12:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/392/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/392/console

Harbormaster failed remote builds in B4155: Diff 3526!Feb 12 2019, 12:19 PM
vlorentz updated this revision to Diff 3530.Feb 12 2019, 12:22 PM
  • rebase
Closed by commit rDCIDX9657abaf20a2: Prevent OriginMetadataIndexer from sending duplicate revisions to… (authored by vlorentz). · Explain WhyFeb 12 2019, 12:23 PM
This revision was automatically updated to reflect the committed changes.
swh-public-ci added a comment.Feb 12 2019, 12:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/394/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/394/console

Harbormaster failed remote builds in B4162: Diff 3530!Feb 12 2019, 12:24 PM

Revision Contents
Changeset List

PathSize
swh/
indexer/
17 lines
tests/
22 lines

Diff 3530

View Options

swh/indexer/metadata.py

Loading...
View Options

swh/indexer/tests/test_origin_metadata.py

Loading...
About · Developer information · Legal